Skip to content

Conversation

@SuberFu
Copy link
Contributor

@SuberFu SuberFu commented Mar 16, 2016

Rebased version of #166
Added unit-tests for fileRemoved event.
Testing three cases that should fire fileRemoved event.

  1. Adding a second file when in single-file mode.
  2. Calling Flow.removeFile.
  3. Calling FlowFile.cancel.

Test involves checking if the event if fired, and if the first argument passed in is the FlowFile being removed.

@evilaliv3
Copy link
Member

good to go!

got the next time @SuberFu you were able simply to do "git rebase upstream master" and then force push on your master.
automatically the pull requests would have been updated!

evilaliv3 added a commit that referenced this pull request Mar 16, 2016
Add unit-tests for fileRemove event.
@evilaliv3 evilaliv3 merged commit e30eb63 into flowjs:master Mar 16, 2016
@SuberFu
Copy link
Contributor Author

SuberFu commented Mar 16, 2016

Ooh, didn't know that.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants