Skip to content

Conversation

chendiw
Copy link
Contributor

@chendiw chendiw commented Apr 12, 2020

Pull request information

  • Status: ready to merge (ready to merge / in development)
  • Kind of changes: ? (bug fix / new feature / documentation...)
  • Related PR or issue: ? (optional)

Description

moved imports specific to rllib, stable baselines and h-baselines under functions in train.py (general description)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5752

  • 9 of 13 (69.23%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 89.455%

Changes Missing Coverage Covered Lines Changed/Added Lines %
examples/train.py 9 13 69.23%
Files with Coverage Reduction New Missed Lines %
examples/train.py 1 64.63%
Totals Coverage Status
Change from base Build 5645: -0.04%
Covered Lines: 9331
Relevant Lines: 10431

💛 - Coveralls

@AboudyKreidieh AboudyKreidieh self-requested a review April 21, 2020 22:14
Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AboudyKreidieh AboudyKreidieh merged commit 95e63a8 into master Apr 21, 2020
@AboudyKreidieh AboudyKreidieh deleted the train_imports branch April 21, 2020 22:14
brentgryffindor pushed a commit that referenced this pull request May 18, 2020
* deleting unworking params from SumoChangeLaneParams

* deleted unworking params, sublane working in highway
:

* moved imports inside functions

* Apply suggestions from code review

* bug fixes

* bug fix

Co-authored-by: Aboudy Kreidieh <[email protected]>
liljonnystyle pushed a commit that referenced this pull request May 26, 2020
* deleting unworking params from SumoChangeLaneParams

* deleted unworking params, sublane working in highway
:

* moved imports inside functions

* Apply suggestions from code review

* bug fixes

* bug fix

Co-authored-by: Aboudy Kreidieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants