Skip to content

fix: 2154 - refresh loading tile even without default error image #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 2154 - refresh loading tile even without default error image #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import 'package:flutter_map_example/pages/secondary_tap.dart';
import 'package:flutter_map_example/pages/single_world_polys.dart';
import 'package:flutter_map_example/pages/sliding_map.dart';
import 'package:flutter_map_example/pages/tile_builder.dart';
import 'package:flutter_map_example/pages/tile_error.dart';
import 'package:flutter_map_example/pages/tile_loading_error_handle.dart';
import 'package:flutter_map_example/pages/wms_tile_layer.dart';
import 'package:flutter_web_plugins/url_strategy.dart';
Expand All @@ -55,6 +56,7 @@ class MyApp extends StatelessWidget {
AbortObsoleteRequestsPage.route: (context) =>
const AbortObsoleteRequestsPage(),
PolylinePage.route: (context) => const PolylinePage(),
TileErrorPage.route: (context) => const TileErrorPage(),
SingleWorldPolysPage.route: (context) => const SingleWorldPolysPage(),
PolylinePerfStressPage.route: (context) =>
const PolylinePerfStressPage(),
Expand Down
41 changes: 41 additions & 0 deletions example/lib/pages/tile_error.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import 'package:flutter/material.dart';
import 'package:flutter_map/flutter_map.dart';
import 'package:flutter_map_example/widgets/drawer/menu_drawer.dart';

/// Example of tile loading systematically failing.
class TileErrorPage extends StatelessWidget {
static const String route = '/tile_error';

const TileErrorPage({super.key});

@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: const Text('Tile Error')),
drawer: const MenuDrawer(TileErrorPage.route),
body: FlutterMap(
options: const MapOptions(
initialZoom: 3,
),
children: [
TileLayer(
// obviously wrong url template
urlTemplate: 'https://example.com/{z}/{y}/{x}',
tileBuilder: (context, tileWidget, tile) {
if (tile.loadError) {
return Center(
child: Text('${tile.coordinates.z}'
'/'
'${tile.coordinates.x}'
'/'
'${tile.coordinates.y}'),
);
}
return tileWidget;
},
),
],
),
);
}
}
6 changes: 6 additions & 0 deletions example/lib/widgets/drawer/menu_drawer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import 'package:flutter_map_example/pages/secondary_tap.dart';
import 'package:flutter_map_example/pages/single_world_polys.dart';
import 'package:flutter_map_example/pages/sliding_map.dart';
import 'package:flutter_map_example/pages/tile_builder.dart';
import 'package:flutter_map_example/pages/tile_error.dart';
import 'package:flutter_map_example/pages/tile_loading_error_handle.dart';
import 'package:flutter_map_example/pages/wms_tile_layer.dart';
import 'package:flutter_map_example/widgets/drawer/menu_item.dart';
Expand Down Expand Up @@ -162,6 +163,11 @@ class MenuDrawer extends StatelessWidget {
routeName: ScaleBarPage.route,
currentRoute: currentRoute,
),
MenuItemWidget(
caption: 'Tile error',
routeName: TileErrorPage.route,
currentRoute: currentRoute,
),
const Divider(),
MenuItemWidget(
caption: 'Repeated Worlds/Longitudes',
Expand Down
7 changes: 1 addition & 6 deletions lib/src/layer/tile_layer/tile_image.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ class TileImage extends ChangeNotifier {
loadError = true;

if (!_disposed) {
if (errorImage != null) _display();
_display();
onLoadError(this, exception, stackTrace);
onLoadComplete(coordinates);
}
Expand All @@ -184,11 +184,6 @@ class TileImage extends ChangeNotifier {
loadFinishedAt = DateTime.now();

if (loadError) {
assert(
errorImage != null,
'A TileImage should not be displayed if loading errors and there is no '
'errorImage to show.',
);
_readyToDisplay = true;
if (!_disposed) notifyListeners();
return;
Expand Down