-
Notifications
You must be signed in to change notification settings - Fork 537
use ffi::TensorView
instead of ffi::Tensor
#1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a PR to update the tvm-ffi version in docker container first.
Queued after #1857 |
/bot run |
@cyx-6 would you mind double checking whether there are remaining usage of If we have fixed all usage and https://gitlab-master.nvidia.com/dl/flashinfer/flashinfer-ci/-/pipelines/36450141 doesn't introduce new regression, we can merge this PR. |
/bot run |
[SUCCESS] Pipeline #36453969: 11/17 passed |
📌 Description
This PR migrates the arguments from
ffi::Tensor
instead offfi::TensorView
.ffi::Tensor
: Owning tensor friendly totorch.Tensor
.ffi::TensorView
: Non-owning tensor, equivalent todltensor*
, which is commonly used in JAX/XLA.So we do such migration for broader support.
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commit
by runningpip install pre-commit
(or used your preferred method).pre-commit install
.pre-commit run --all-files
and fixed any reported issues.🧪 Tests
unittest
, etc.).Reviewer Notes