Fix the volatileGet to not revert with OutOfGas Error when key does not exist #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue convention" This reverts commit 565c48c.
MoeMahhouk
force-pushed
the
main
branch
3 times, most recently
from
8105e10 to
5e2ac5e
Compare
…tatus/Value convention"" This reverts commit dd73623.
Ruteri
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
We fixed the issue with volatileGet precompile function upon calling it with key that doesnt exist.
It returns an err, however, it also reverts the whole execution with OutOfGas (gas_used =18158513697557840303)
To avoid such an issue and still be able to handle a non-existing key from the smart contract side:
1- Instead of reverting with an error, we return a status and a value. The status would mark if the key exists or not.
If the key exists, the value will be set accordingly. If not, it will return 0 bytes array with a failure status (false)
2- Added unit tests for existing and non-existing keys