added instructions for AWS #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreeaflorescu
suggested changes
Jan 8, 2019
docs/dev-machine-setup.md
Outdated
| Firecracker development environment on AWS can be setup using bare metal instances. Follow these steps to create a bare metal instance. | ||
|
|
||
| 1. If you don't already have an AWS account, create one: https://portal.aws.amazon.com/billing/signup. | ||
| 1. Install AWS CLI: https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-install.html |
There was a problem hiding this comment.
This step is not mandatory because you can start the instance from the AWS console. Also, it seems like you are not using the AWS cli anyway.
dianpopa
reviewed
Jan 8, 2019
docs/dev-machine-setup.md
Outdated
| 1. Login to the newly created instance: | ||
|
|
||
| ``` | ||
| ssh -i <ssh-key> ubunut@<public-ip> |
There was a problem hiding this comment.
Suggested change
| ssh -i <ssh-key> ubunut@<public-ip> | |
| ssh -i <ssh-key> ubuntu@<public-ip> |
docs/dev-machine-setup.md
Outdated
| ``` | ||
|
|
||
| Now you can continue with the Firecracker [Getting Started](getting-started.md) | ||
| instructions to install and configure Firecracker in the new VM. |
There was a problem hiding this comment.
I would rephrase this sentence (i.e ...instructions to install and configure Firecracker in the new VM) since you are not installing Firecracker in a VM you are using Firecracker to spawn a microVM.
docs/dev-machine-setup.md
Outdated
| ### AWS | ||
|
|
||
| `[TODO]` | ||
| Firecracker development environment on AWS can be setup using bare metal instances. Follow these steps to create a bare metal instance. |
There was a problem hiding this comment.
Can you make you all the lines maximum 80 characters long?
docs/dev-machine-setup.md
Outdated
| `[TODO]` | ||
| Firecracker development environment on AWS can be setup using bare metal instances. Follow these steps to create a bare metal instance. | ||
|
|
||
| 1. If you don't already have an AWS account, create one: https://portal.aws.amazon.com/billing/signup. |
There was a problem hiding this comment.
nit: do not use bare URL in markdown. One suggestion would be to re-write it as:
... create on using the [AWS portal](https://portal.aws.amazon.com/billing/signup).
or whatever else sounds better.
docs/dev-machine-setup.md
Outdated
| Firecracker development environment on AWS can be setup using bare metal instances. Follow these steps to create a bare metal instance. | ||
|
|
||
| 1. If you don't already have an AWS account, create one: https://portal.aws.amazon.com/billing/signup. | ||
| 1. Login to AWS console: https://console.aws.amazon.com/console/home?region=us-east-1. Bare metal instances are only supported in `US East (N. Virginia)` region at this time. This region is preselected for you in the Console. |
There was a problem hiding this comment.
Bare URL, can you re-write it as:
Login to the [AWS Console](https://console.aws.amazon.com/console/home?region=us-east-1).
arun-gupta
force-pushed
the
work
branch
3 times, most recently
from
a641260 to
d64c587
Compare
Signed-off-by: Arun Gupta <[email protected]>
Signed-off-by: Arun Gupta <[email protected]>
andreeaflorescu
approved these changes
Jan 15, 2019
dianpopa
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.