Maintenance 2 #5471
Open
Maintenance 2 #5471
+60
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5471 +/- ##
==========================================
+ Coverage 82.74% 82.80% +0.06%
==========================================
Files 269 269
Lines 27798 27752 -46
==========================================
- Hits 23001 22980 -21
+ Misses 4797 4772 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
maintenance_2
branch
8 times, most recently
from
50da2f7 to
8036a6a
Compare
ShadowCurse
requested review from
Manciukic and
bchalios
and removed request for
Manciukic
Manciukic
reviewed
Oct 16, 2025
Comment on lines
524
to
+533
| }) | ||
| .map_err(VmmError::FindDeviceError) | ||
| .map_err(VmmError::FindDeviceError)??; | ||
| Ok(()) |
There was a problem hiding this comment.
can this be just?
.map_err(VmmError::FindDeviceError)?
maybe not because it needs to convert it first.
maybe this would work?
})?
.map_err(VmmError::Block)
}
The only place where anyhow was used is in the device manager code that runs a specified function with a certain device. No instead of converting the possible error of that function to anyhow::error, just return the error and lest the call site do deal with it. Signed-off-by: Egor Lazarchuk <[email protected]>
When we get a type erased device from a underlying device storage we expect that it will always be of the type we requested with T::const_device_type(). If it is not true, we have an internal bug. Signed-off-by: Egor Lazarchuk <[email protected]>
with_virtio_device_with_id was never used in the mmio device manager. Signed-off-by: Egor Lazarchuk <[email protected]>
Replace 2 functions: `try_with_virtio_device_with_id` and `with_virtio_device_with_id`, with single `with_virtio_device` that handles any return type of the passed function. Signed-off-by: Egor Lazarchuk <[email protected]>
This wrapper was only used in the `update_from_restored_device` function which was instantly unwrapping the value and just adding device to the VmResources. Instead of this round trip just add devices directly since fields are public. This also removes the check for the addition of balloon device, but this check is not needed anyway, since snapshot should not contain conflicting configs. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
maintenance_2
branch
from
8036a6a to
4fde8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
anyhowusageMmioDeviceManagerSharedDeviceTypewrapperReason
Codebase maintenance
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.