update Audit interface to include eventKey and userId field #332
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The current Audit interface in src/types.ts of the Fireblocks SDK is missing two crucial fields: userId and eventKey. However, these fields are present in the actual response payload returned by the getPaginatedAuditLogs method. This discrepancy causes type mismatches or loss of type safety when consuming audit log responses. This PR adds the missing userId and eventKey fields to the Audit interface to align the SDK typings with the actual API response and enable proper type-safe usage.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran build command and used the new custom SDK in my Express app. Works fine now and I do not see the compile-time error. I am using Typescript in the Express app.
Checklist: