Skip to content

Update to new modular Admin SDK #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 15, 2021
Merged

Update to new modular Admin SDK #220

merged 28 commits into from
Oct 15, 2021

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Apr 16, 2021 •
edited
Loading

Breaking:

  • Update to new Admin SDK
  • Drop Node 10 support

Products:

  • auth
  • config
  • database
  • firebaseapp
  • firestore
  • functions
  • management
  • messaging
  • storage

TODO Before Submit:

  • Figure out how to make it work with firebase-functions
  • Replace exp with real version

TODO After Submit:

  • Update auth custom claims functions snippet (it moved)

@samtstern samtstern requested a review from davideast April 16, 2021 14:01
@samtstern
Copy link
Contributor Author

cc @hiranya911 just FYI

@google-cla google-cla bot added the cla: yes label May 13, 2021
@samtstern samtstern requested a review from egilmorez May 13, 2021 13:28
egilmorez
egilmorez approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good to me, snippet-wise. Noted the one moved snippet, but it looks like the name stays the same. :)

@egilmorez
Copy link
Collaborator

Going to go ahead and merge this and publish the docs that contain these. Thanks!

@egilmorez egilmorez merged commit 7981446 into master Oct 15, 2021
@samtstern samtstern mentioned this pull request Oct 15, 2021
Merged
@samtstern
Copy link
Contributor Author

This was accidentally non-squash merged so I reverted (via a force-push) and did the actual merge in:
#268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@davideast davideast Awaiting requested review from davideast

+1 more reviewer

@manfredwedderin manfredwedderin manfredwedderin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samtstern @egilmorez @manfredwedderin