Skip to content

Fix: Refactor constructor Key.php to use PHP 8.0 syntax #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Fix: Refactor constructor Key.php to use PHP 8.0 syntax #577

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d02055
Refactor constructor Key.php to use PHP 8.0 syntax
margar-melkonyan Sep 21, 2024
7c45976
Merge branch 'main' into refactor
bshaffer Nov 24, 2024
35b1817
Merge branch 'main' into refactor
margar-melkonyan Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/Key.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,13 @@

class Key
{
/** @var string|resource|OpenSSLAsymmetricKey|OpenSSLCertificate */
private $keyMaterial;
/** @var string */
private $algorithm;

/**
* @param string|resource|OpenSSLAsymmetricKey|OpenSSLCertificate $keyMaterial
* @param string $algorithm
*/
public function __construct(
$keyMaterial,
string $algorithm
private $keyMaterial,
private string $algorithm
) {
if (
!\is_string($keyMaterial)
Expand All @@ -38,10 +33,6 @@ public function __construct(
if (empty($algorithm)) {
throw new InvalidArgumentException('Algorithm must not be empty');
}

// TODO: Remove in PHP 8.0 in favor of class constructor property promotion
$this->keyMaterial = $keyMaterial;
$this->algorithm = $algorithm;
}

/**
Expand Down
Loading