Allow overriding default headers #473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'typ' and 'alg' headers are currently set by default, and cannot be overridden with the $head parameter. This change would still keep the default headers, but would allow developers to override it if they so choose. One such use case would be to create a JWT of "typ": "passport", as per the stir/shaken requirements.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I could see allowing "typ" to be specified, but I don't see a reason to allow "alg". Do you have one? |
|
Thank you for the contribution, closing this PR as the parent issue got closed. Please feel free to re-open the thread to discuss further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'typ' and 'alg' headers are currently set by default, and cannot be overridden with the $head parameter. This change would still keep the default headers, but would allow developers to override it if they so choose.
One such use case would be to create a JWT of "typ": "passport", as per the stir/shaken requirements.