Skip to content

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Nov 17, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Remove an attempt to support tvOS for Firestore in the Editor/Builder.cs code. This failed to compile due to Unity not being able to resolve the tvOSSdkVersion enumerated type, for some reason.

However, it seems that these methods aren't invoked anywhere. Removing for now. Will add back and fix if Firestore fails to build for tvOS in future testing.


Testing

Describe how you've tested these changes.

Integration Test CI


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta marked this pull request as ready for review November 17, 2022 16:20
@DellaBitta DellaBitta requested a review from a-maurice November 17, 2022 21:26
@DellaBitta DellaBitta merged commit ba1dd7d into main Nov 17, 2022
@DellaBitta DellaBitta deleted the ddb/firestore_tvos_itest_fix branch November 17, 2022 23:18
@firebase firebase locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants