Set Android common page size to 16 KB

[a-maurice]

Description

Provide details of the change, and generalize the change in the PR title above.

Set the common-page-size to 16 KB as well. Since we currently use an older NDK version (r21e), this additional flag needs to be set to guarantee that some of the internals are aligned correctly to the new file size. https://developer.android.com/guide/practices/page-sizes#compile-r26-lower

Fixes #1259

---

Testing

Describe how you've tested these changes.

Testing locally via emulator
https://github.com/firebase/firebase-unity-sdk/actions/runs/15406475092

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

[gemini-code-assist]

Hello @a-maurice, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #1259 by setting the common-page-size to 16KB for Android builds. This change is necessary because the project uses an older NDK version (r21e), and this flag ensures correct alignment of internals with the new file size. The changes modify the cmake/build_shared.cmake and cmake/build_universal.cmake files to include the -Wl,-z,common-page-size=16384 linker flag. Additionally, the docs/readme.md file is updated to reflect this fix in the upcoming release notes.

Highlights

• Bug Fix: Addresses a crash related to 16KB page sizes on Android (Issue #1259).
• CMake Configuration: Adds the -Wl,-z,common-page-size=16384 linker flag to build_shared.cmake and build_universal.cmake.
• Documentation: Updates docs/readme.md to include a note about the fix in the upcoming release notes.

Changelog

• cmake/build_shared.cmake
  • Added -Wl,-z,common-page-size=16384 linker flag on line 111 to set the common page size to 16KB for Android builds.
• cmake/build_universal.cmake
  • Added -Wl,-z,common-page-size=16384 linker flag on line 91 to set the common page size to 16KB for Android builds.
• docs/readme.md
  • Added a release note on line 76 to indicate that a crash with 16 KB page sizes has been fixed for Android.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

In CMake's realm, a flag's unfurled,
For Android's builds, a fix is hurled.
Sixteen K aligns,
Averting pains,
Stability's promise to the world.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a fix for a crash related to 16KB page sizes on Android by setting the common-page-size linker flag. The changes seem straightforward and address the reported issue. However, I have a few observations regarding the documentation update and the necessity of the added linker flag.

Summary of Findings

• Clarification on linker flags: Need more context on the necessity of both max-page-size and common-page-size linker flags, and whether they are needed for all Android versions or only older NDK versions.
• Improved release note description: Consider adding a brief explanation of the 16 KB page size issue and a direct link to the Android developer documentation in the release notes.

Merge Readiness

The pull request seems to address the reported issue effectively. However, it would be beneficial to clarify the necessity of both linker flags and provide a more detailed description in the release notes. I am unable to approve this pull request, and recommend that others review and approve this code before merging. I recommend addressing the medium severity comments before merging.