Skip to content

Disable new SWIG string helper functions #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
+9 −0
Merged

Disable new SWIG string helper functions #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmake/firebase_swig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@ macro(firebase_swig_add_library name)
# https://github.com/swig/swig/issues/672#issuecomment-400577864
final=
USE_EXPORT_FIX
# SWIG 4.3 added a C# class, SWIGStringWithLengthHelper, but is missing
# the corresponding C++ symbols, which can cause issues. We don't
# rely on this class anyway, so just disable it.
SWIG_CSHARP_NO_STRING_WITH_LENGTH_HELPER
)

set_property(TARGET ${name} PROPERTY SWIG_GENERATED_COMPILE_DEFINITIONS
Expand Down
5 changes: 5 additions & 0 deletions docs/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ Support

Release Notes
-------------
### Upcoming
- Changes
- General: Remove unresolved SWIG string symbols.
([#1139](https://github.com/firebase/firebase-unity-sdk/issues/1139)).

### 12.4.0
- Changes
- General: Update to Firebase C++ SDK version 12.4.0.
Expand Down
Loading