Wrap each warning call site with NODE_ENV check for better dead cod…

[Andarist]

What we've discussed under #204

[codecov]

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #206   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      8    -1     
  Lines         173    174    +1     
  Branches       58     60    +2     
=====================================
+ Hits          173    174    +1

Impacted Files	Coverage Δ
src/ReactFinalForm.js	100% <100%> (ø)	⬆️
src/renderComponent.js	100% <100%> (ø)	⬆️
src/FormSpy.js	100% <100%> (ø)	⬆️
src/Field.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd73fac...6e33223. Read the comment docs.

[erikras]

Having a whole module just to do an if() statement doesn't make sense to me. We're not even saving the "Warning: " string from the bundle size with the dead code removal. Plus, whenever I try to use warning(), I can never remember if true means to print the error or if false means to print the error.

Let's just move the if statements into each call site. Sound good?

[Andarist]

Sure thing - done.

[erikras]

Published in v3.2.1.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.