Code Quality: Removed extra code for async ops in Program class #17100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting your review @dongle-the-gadget @hez2010 |
0x5bfa
force-pushed
the
5bfa/CQ-RunAsSync
branch
2 times, most recently
from
fc48386 to
eca313e
Compare
|
Ready |
|
I think it's better to do something like public Task Something(Task task)
{
async Task Call()
{
await task;
SetEvent();
}
} |
yaira2
force-pushed
the
main
branch
2 times, most recently
from
42c8207 to
4c7493f
Compare
|
@0x5bfa fyi |
|
@ahmed605 What is your opinion too? I can't be sure the current code and the above code is really non blocking. |
|
What's the state of this PR? |
0x5bfa
force-pushed
the
5bfa/CQ-RunAsSync
branch
from
eca313e to
fab5674
Compare
|
Committed the requested change. Itested the change in PTAL. CC: @ahmed605 |
|
LGTM |
0x5bfa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes