Skip to content

Conversation

@frrist
Copy link
Member

@frrist frrist commented Oct 18, 2022

  • closes upgrade to lotus v1.18 #1075
  • TODO @frrist write a description
  • General note: this is running against Calibent, processed the entire chain successfully (1-now), and is actively watching the chain. I intend to monitor this over the week.

@frrist frrist self-assigned this Oct 18, 2022
@frrist frrist force-pushed the frrist/update-lotusv1.18 branch from 12afec1 to 8e4cc14 Compare October 19, 2022 23:16
dockerizer:
docker:
- image: cimg/go:1.17.6
- image: cimg/go:1.18.7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lotus and lily are now on go version 1.18, ci must match; mechanical change in this file.

Version6 Version = 6
Version7 Version = 7
Version8 Version = 8
Version9 Version = 9
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support new actor version

RewardKey = "reward"
SystemKey = "system"
VerifregKey = "verifiedregistry"
DatacapKey = "datacap"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new datacap actor added in v9

@@ -1,4 +1,3 @@
// Code generated by: `make actors-gen`. DO NOT EDIT.
package builtin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all code gen, skip review.

@@ -0,0 +1,58 @@
package datacap
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add minimal support for datacap actor

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

❌ Patch coverage is 16.00000% with 189 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.8%. Comparing base (6e1cfb8) to head (a64fd18).
⚠️ Report is 188 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1080     +/-   ##
========================================
- Coverage    34.2%   32.8%   -1.4%     
========================================
  Files          44      46      +2     
  Lines        2945    3156    +211     
========================================
+ Hits         1008    1037     +29     
- Misses       1841    2023    +182     
  Partials       96      96             
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frrist frrist force-pushed the frrist/update-lotusv1.18 branch 2 times, most recently from 79c2105 to 7162c2d Compare November 16, 2022 20:39
@frrist frrist marked this pull request as ready for review November 16, 2022 21:22
@frrist frrist force-pushed the frrist/update-lotusv1.18 branch from 114d6d8 to 69e6f86 Compare November 21, 2022 21:30
@frrist frrist force-pushed the frrist/update-lotusv1.18 branch from 01be0ba to cd31965 Compare November 22, 2022 21:16
Copy link
Member Author

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments on files needing extra attention for review

@@ -0,0 +1,203 @@
package miner
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File needs review

@@ -0,0 +1,137 @@
package datacap
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file needs review

@frrist frrist merged commit 56e9595 into master Nov 29, 2022
@frrist frrist deleted the frrist/update-lotusv1.18 branch November 29, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade to lotus v1.18

4 participants