feat: implement parallel diffing #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
May 3, 2022
frrist
force-pushed
the
frrist/parallel-diff
branch
from
8b26370 to
bbeb31c
Compare
frrist
force-pushed
the
frrist/parallel-diff
branch
from
bbeb31c to
6d7ae35
Compare
Stebalien
suggested changes
May 4, 2022
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
Also, in general, you need to either:
- Select on the context everywhere.
- Ensure that you drain channels everywhere.
It's usually easier to select on the context and just let everything shut down async. But it's cleaner to carefully drain channels. Up to you.
- seems CI is resource contratined, these test pass locally in ~30sec
Stebalien
reviewed
May 4, 2022
Stebalien
reviewed
May 4, 2022
Stebalien
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Used in a test branch of lily filecoin-project/lily#880 where we observed a significant speed up (from mins to milliseconds) in its processing pipeline (diffing actor states, state-trees, miner and market HAMTs).
What
doParallelDiffNodeis mostly a copy ofdiffNodewith the addition of an errgroup to parallelize recursive access.doparallelDiffNodeis called from withindiffAndAssertLengthfor all tests.ParallelDiffaccepts amaxWorkersthat limits (approximately) the number of goroutines created.