feat: implement parallel diffing #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 60.94% 64.60% +3.65%
==========================================
Files 8 9 +1
Lines 973 1308 +335
==========================================
+ Hits 593 845 +252
- Misses 257 313 +56
- Partials 123 150 +27
|
frrist
force-pushed
the
frrist/parallel-diff
branch
from
aec3477 to
781fdc5
Compare
Closed
frrist
commented
Apr 28, 2022
|
|
||
| type mockBlocks struct { | ||
| data map[cid.Cid]block.Block | ||
| dataMu sync.Mutex |
There was a problem hiding this comment.
required to prevent race condition in test since ParallelDiff accesses the store in parallel
frrist
force-pushed
the
frrist/parallel-diff
branch
from
781fdc5 to
eb347a2
Compare
Stebalien
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Explored idea in #62 with bench-marking and was able to achieve a 2-3x speed up (bitwidth of 5-6) vs serial diffing. Furthermore #62 was used in a test branch of lily filecoin-project/lily#880 where we observed a significant speed up (from mins to milliseconds) in its processing pipeline (diffing actor states, state-trees, miner and market AMTs).
What
parallelDiffNodeis mostly a copy ofdiffNodewith the addition of an errgroup to parallelize recursive access.parallelDiffNodeis called from withindiffAndAssertLengthfor all tests.