fix(diff): handle edge case diffing empty against non-empty #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frrist
commented
Jun 21, 2021
frrist
commented
- and add tests
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 65.75% 66.02% +0.26%
==========================================
Files 6 6
Lines 514 518 +4
==========================================
+ Hits 338 342 +4
Misses 93 93
Partials 83 83
Continue to review full report at Codecov.
|
rvagg
reviewed
Jun 21, 2021
diff.go
Outdated
|
|
||
| // edge case of diffing an empty AMT against non-empty | ||
| if prevAmt.count == 0 && curAmt.count != 0 { | ||
| return addAll(ctx, curCtx, curAmt.node,0) |
rvagg
approved these changes
Jun 21, 2021
- and add tests
frrist
force-pushed
the
frrist/fix-empty-diff
branch
from
f2b3529 to
ff5bb27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.