-
Notifications
You must be signed in to change notification settings - Fork 5
feat: allow overriding withCDN via env-var #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
14ddf56
feat: allow overriding withCDN via env-var
SgtPooki 0b82e20
chore: fix lint
SgtPooki e37c582
docs: indicate default value for WITH_CDN
SgtPooki e687b57
fix: Warn users when enabling WITH_CDN
SgtPooki 1fd8fab
docs: update readme
SgtPooki 1170fdd
Merge branch 'master' into feat/allow-with-cdn-override
SgtPooki 2351d1b
chore: fix bad merge
SgtPooki 5e25fd0
chore: remove envToBool
SgtPooki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** | ||
| * Generic helpers for environment variable parsing and validation. | ||
| */ | ||
|
|
||
| export const envToBool = (value: string | undefined, defaultValue: boolean): boolean => { | ||
| if (value === undefined) return defaultValue | ||
| const normalized = value.trim().toLowerCase() | ||
| if (['1', 'true', 'yes', 'on'].includes(normalized)) return true | ||
| if (['0', 'false', 'no', 'off'].includes(normalized)) return false | ||
| return defaultValue | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.