Refactor promise type logic #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This is an amazing fix! Great work! |
Owner
|
Perhaps we could just add a simple unit test for this scenario? |
Contributor
|
Very nice @notanengineercom :) The code looks good again. I was not comfortable with my implementation, there was too many conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #86
Either Typescript type inheritance is doing something weird, or we are missing something, but refactoring the promise type to extend
BaseMockObjectMixinseems to get it right!The MockObjectPromise type is only applied when the return type of a method or property is a promise.
As I said in the comment on the issue, we need to add tests for as many types as possible, so we can avoid weird issues like with the boolean