Skip to content

Fix use of uninitialized memory and a memory leak #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix use of uninitialized memory and a memory leak #1

wants to merge 4 commits into from

Conversation

@swrh
Copy link

@swrh swrh commented Dec 16, 2015

Hi, this PR fixes three bugs:

  • uninitialized memory usage in packet sending -- rudp_peer_send_connect() and peer_send_queue()
  • memory leak at client structure termination -- rudp_client_deinit()

I hope you apply it. Thanks.

swrh added 4 commits February 22, 2016 10:18
@swrh
Fixed uninitialized memory usage in packet sending.
bed86cd
@swrh
Fixed a memory leak.
5228795
@swrh
Avoid crash when rudp_client_close() is called.
83eb9e6 
Added a couple of pointer verifications to avoid crashes when
rudp_client_close() is called before rudp_client_connect() or at the
server_lost() handler.
@swrh
Fix use of freed memory on server when peer drops.
fea4326
@swrh
Copy link
Author

swrh commented Feb 22, 2016

Shame on me, hehe, I did a rebase on this branch. I removed the autogen.sh commit (no need, I agree) and added two more fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@swrh