Skip to content

Conversation

@yujonglee
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jul 25, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change introduces multi-language support throughout the application's speech-to-text and listener configuration. It replaces single language fields with vectors of languages in configuration structs, APIs, and builder patterns. UI components are updated to allow users to select multiple spoken languages, and localization files are expanded to support these new options. Serialization and deserialization logic is adapted to handle the new data structures.

Changes

Files/Paths Change Summary
Cargo.toml, crates/language/Cargo.toml, plugins/local-stt/Cargo.toml Updated and added dependencies (axum, axum-extra, schemars, specta), enabled features for language and query support.
apps/app/server/src/native/listen/realtime.rs, apps/app/server/src/native/listen/recorded.rs Changed STT engine initialization to use the first language from a language list instead of a single language string.
apps/desktop/src/components/settings/views/general.tsx Added multi-select spoken languages field to settings UI, fixed display language to English, improved jargon field.
apps/desktop/src/locales/en/messages.po, apps/desktop/src/locales/ko/messages.po Updated and expanded translation entries for new language and vocabulary UI; marked obsolete entries.
crates/db-user/src/config_types.rs Added spoken_languages field to config struct, removed custom serde logic for display_language.
crates/language/src/lib.rs Changed Language struct derives, added schema annotations, implemented custom serde logic for string-based serialization.
crates/whisper-local/src/model.rs Refactored to support multiple languages in builder, model, and transcription; added language detection among configured set.
crates/whisper/src/lib.rs Added #[repr(u8)], derived traits, and whisper_index method to Language enum.
plugins/db/js/bindings.gen.ts Added spoken_languages property to ConfigGeneral type.
plugins/listener-interface/src/lib.rs Replaced single language field with languages: Vec<...> in ListenParams, removed custom serialization helpers.
plugins/listener/src/client.rs Appends multiple languages as query parameters in WebSocket URI; updated tests accordingly.
plugins/listener/src/fsm.rs Refactored to use and propagate multiple languages in session setup and client initialization.
plugins/local-stt/src/ext.rs Explicitly sets languages to an empty vector in model builder.
plugins/local-stt/src/lib.rs Updated test to use languages vector instead of single language.
plugins/local-stt/src/server.rs Updated import for Query, filtered and converted languages for model builder.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DesktopUI
    participant ConfigStore
    participant ListenerClient
    participant STTModel

    User->>DesktopUI: Selects spoken languages in settings
    DesktopUI->>ConfigStore: Saves spoken_languages (array)
    DesktopUI->>ListenerClient: Starts listening with spoken_languages
    ListenerClient->>STTModel: Initializes with spoken_languages
    STTModel->>STTModel: Detects/uses appropriate language for transcription
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d1bcc7 and 9fdaa1a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (19)
  • Cargo.toml (1 hunks)
  • apps/app/server/src/native/listen/realtime.rs (1 hunks)
  • apps/app/server/src/native/listen/recorded.rs (1 hunks)
  • apps/desktop/src/components/settings/views/general.tsx (10 hunks)
  • apps/desktop/src/locales/en/messages.po (15 hunks)
  • apps/desktop/src/locales/ko/messages.po (15 hunks)
  • crates/db-user/src/config_types.rs (2 hunks)
  • crates/language/Cargo.toml (1 hunks)
  • crates/language/src/lib.rs (2 hunks)
  • crates/whisper-local/src/model.rs (7 hunks)
  • crates/whisper/src/lib.rs (2 hunks)
  • plugins/db/js/bindings.gen.ts (1 hunks)
  • plugins/listener-interface/src/lib.rs (1 hunks)
  • plugins/listener/src/client.rs (2 hunks)
  • plugins/listener/src/fsm.rs (5 hunks)
  • plugins/local-stt/Cargo.toml (2 hunks)
  • plugins/local-stt/src/ext.rs (1 hunks)
  • plugins/local-stt/src/lib.rs (1 hunks)
  • plugins/local-stt/src/server.rs (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch language-detect-constraint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yujonglee yujonglee merged commit 3f71bc1 into main Jul 25, 2025
7 of 8 checks passed
@yujonglee yujonglee deleted the language-detect-constraint branch July 25, 2025 21:19
@coderabbitai coderabbitai bot mentioned this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants