Skip to content

chore(.npmrc): ignore scripts #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(.npmrc): ignore scripts #234

wants to merge 2 commits into from

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Sep 18, 2025

See fastify/deepmerge#78. This is a batch PR created by a script. Please review prior to merging.

@Uzlopak
Copy link
Collaborator

Uzlopak commented Sep 18, 2025

@Fdawgs

I modified it. WDYT?

@Fdawgs
Copy link
Member Author

Fdawgs commented Sep 19, 2025

@Fdawgs

I modified it. WDYT?

I wonder if we can make it so that scripts/prepare-swagger-ui.js is called on first run of the index.js and have a global variable there indicating whether it's built, so it's not rebuilt every time? That way we can get rid of having to call it separately?

mcollina
mcollina approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina requested changes Sep 20, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a different approach here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fdawgs @Uzlopak @mcollina