Skip to content

Conversation

@bossm8
Copy link

@bossm8 bossm8 commented May 2, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falcosidekick-chart

/area falco-talon-chart

/area event-generator-chart

/area k8s-metacollector-chart

What this PR does / why we need it:

Currently the grafana folder annotation is hardcoded to grafana_dashboard_folder but many other charts use grafana_folder instead, which thus is the case in many installations. This PR allows to specify a custom annotation but ensures backwards compatibility as the default is still grafana_dashboard_folder.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I've already fixed the corrisponding labels in GitHub

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented May 2, 2025

Welcome @bossm8! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana
Copy link
Contributor

poiana commented May 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bossm8
Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/L label May 2, 2025
@poiana poiana requested review from Issif and bencer May 2, 2025 14:56
@bossm8
Copy link
Author

bossm8 commented May 2, 2025

Just realized that we probably want folderAnnotation in addition to folder instead of folder.name and folder.annotation since the latter breaks current deployment values. I'll push this in the next few days.

…r.annotation for backwards compatibility

Signed-off-by: Boss Marco <[email protected]>
@bossm8 bossm8 force-pushed the fb/custom-folder-annotations branch from 0b0ddf6 to ac683d6 Compare May 3, 2025 05:51
@poiana
Copy link
Contributor

poiana commented May 5, 2025

@bossm8: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bossm8
Copy link
Author

bossm8 commented May 5, 2025

/assign

@bossm8
Copy link
Author

bossm8 commented Jun 12, 2025

Any chance this will be looked at? Then I'll resolve the conflicts.

@leogr
Copy link
Member

leogr commented Aug 14, 2025

Any chance this will be looked at? Then I'll resolve the conflicts.

I did a quick review, and it SGTM. cc @cpanato for a 2nd look

@poiana
Copy link
Contributor

poiana commented Nov 12, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Nov 17, 2025

/remove-lifecycle stale
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants