-
Notifications
You must be signed in to change notification settings - Fork 312
feat: allow specifying folder annotation for grafana dashboards #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Boss Marco <[email protected]>
|
Welcome @bossm8! It looks like this is your first PR to falcosecurity/charts 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bossm8 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Boss Marco <[email protected]>
|
Just realized that we probably want |
…r.annotation for backwards compatibility Signed-off-by: Boss Marco <[email protected]>
0b0ddf6 to
ac683d6
Compare
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign |
Signed-off-by: Boss Marco <[email protected]>
|
Any chance this will be looked at? Then I'll resolve the conflicts. |
I did a quick review, and it SGTM. cc @cpanato for a 2nd look |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
|
/remove-lifecycle stale |

What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
/area falcosidekick-chart
/area falco-talon-chart
/area k8s-metacollector-chart
What this PR does / why we need it:
Currently the grafana folder annotation is hardcoded to
grafana_dashboard_folderbut many other charts usegrafana_folderinstead, which thus is the case in many installations. This PR allows to specify a custom annotation but ensures backwards compatibility as the default is stillgrafana_dashboard_folder.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I've already fixed the corrisponding labels in GitHub
Checklist