Skip to content

Conversation

@Shinigami92
Copy link
Member

use node 24 in ci
should be merged after #3536 got merged
also we need to add the node-24 checks in the branch ruleset

@Shinigami92 Shinigami92 added this to the v10.0 milestone Jun 29, 2025
@Shinigami92 Shinigami92 self-assigned this Jun 29, 2025
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 29, 2025 15:01
@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Jun 29, 2025
@netlify
Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 01993b1
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/686453a8b081ec00084a464a
😎 Deploy Preview https://deploy-preview-3543.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (1f03291) to head (01993b1).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3543   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2888     2888           
  Lines      222112   222112           
  Branches      951      951           
=======================================
  Hits       222059   222059           
  Misses         53       53           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Jul 3, 2025
Merged via the queue into next with commit a4886ee Jul 3, 2025
26 checks passed
@xDivisionByZerox xDivisionByZerox deleted the ci-node-24 branch July 3, 2025 15:56
Shinigami92 added a commit that referenced this pull request Jul 3, 2025
test: disable lint rules for commonjs files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: infra Changes to our infrastructure or project setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants