Skip to content

Conversation

@M1r1k
Copy link
Contributor

@M1r1k M1r1k commented Apr 17, 2015

Right now it depends on #170

rules.info.yml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this one is called test_dependencies :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be called RulesServiceProvider and must be placed into the Drupal\rules namespace to let Drupal find it

@fubhy
Copy link
Collaborator

fubhy commented Apr 17, 2015

Please call the namespace WebProfiler (camel case) as well and also the files themselves!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSR3 constants please.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... No :P

@M1r1k M1r1k changed the title Init commit for webprofiler integration WebProfiler debugging integration Apr 18, 2015
@dasjo
Copy link
Collaborator

dasjo commented Jul 26, 2015

Merged back head into the webprofiler branch here:
https://github.com/dasjo/rules/tree/webprofiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants