Skip to content

Conversation

@ajkr
Copy link
Contributor

@ajkr ajkr commented Dec 20, 2017

added support for C and asm files as required for e612e31.

Test Plan: Adam said build succeeds now.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ajkr ajkr requested a review from sagar0 January 3, 2018 19:17
@adamretter
Copy link
Contributor

@ajkr This fixes the build on PPC64le. Thanks... Although I can't comment on its correctness

@sagar0
Copy link
Contributor

sagar0 commented Jan 3, 2018

I too verified just now that this fixes PPC64le build on 5.9.fb branch.
However this alone is not sufficient to fix the build break on master for 'make rocksdbjavastatic' target, and #3260 or an equivalent is needed.

@adamretter
Copy link
Contributor

Closes #3315

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ajkr added a commit that referenced this pull request Jan 11, 2018
Summary:
added support for C and asm files as required for e612e31.
Closes #3299

Differential Revision: D6612479

Pulled By: ajkr

fbshipit-source-id: 6263ed7c1602f249460421825c76b5721f396163
ajkr added a commit that referenced this pull request Jan 11, 2018
Summary:
added support for C and asm files as required for e612e31.
Closes #3299

Differential Revision: D6612479

Pulled By: ajkr

fbshipit-source-id: 6263ed7c1602f249460421825c76b5721f396163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants