Skip to content

Expose LoadLatestOptions, LoadOptionsFromFile and GetLatestOptionsFileName APIs in RocksJava #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Expose LoadLatestOptions, LoadOptionsFromFile and GetLatestOptionsFileName APIs in RocksJava #2898

wants to merge 1 commit into from

Conversation

@sagar0
Copy link
Contributor

@sagar0 sagar0 commented Sep 18, 2017

JNI wrappers for LoadLatestOptions, LoadOptionsFromFile and GetLatestOptionsFileName APIs.

Test Plan:
Added new junit tests.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 18, 2017

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@sagar0 sagar0 requested a review from adamretter September 19, 2017 17:45
@sagar0 sagar0 changed the title Java APIs for LoadLatestOptions, LoadOptionsFromFile and GetLatestOptionsFileName Expose LoadLatestOptions, LoadOptionsFromFile and GetLatestOptionsFileName APIs in RocksJava Sep 19, 2017
@siying
Copy link
Contributor

siying commented Sep 21, 2017

Is there any .md file to update for the adding the API?

@sagar0
Copy link
Contributor Author

sagar0 commented Sep 21, 2017

There is HISTORY-JAVA.md, but it hasn't been updated in over 2 years.

siying
siying approved these changes Sep 21, 2017
View reviewed changes
java/rocksjni/options_util.cc
if (jcfd != nullptr) {
env->DeleteLocalRef(jcfd);
}
return;
Copy link
Contributor

@siying siying Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to clear the objects already put in cf_descs?

java/rocksjni/options_util.cc
if (jcfd != nullptr) {
env->DeleteLocalRef(jcfd);
}
return;
Copy link
Contributor

@siying siying Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 21, 2017

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@sagar0 sagar0 deleted the java-reload-options branch September 23, 2017 20:31
@sagar0 sagar0 mentioned this pull request Oct 9, 2017
Closed
facebook-github-bot pushed a commit that referenced this pull request Oct 12, 2017
@sagar0 @facebook-github-bot
Add OptionsUtil class to java/CMakeLists.txt
cc67b22 
Summary:
Adding OptionsUtil java class and options_util.cc to java/CMakeLists.txt, which were missed accidentally when they were introduced in #2898.
Closes #2985

Differential Revision: D6015878

Pulled By: sagar0

fbshipit-source-id: 1abbd46db4aebad1e07ea53523eacbdcb12823e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamretter adamretter Awaiting requested review from adamretter

1 more reviewer

@siying siying siying approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed java-api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sagar0 @facebook-github-bot @siying @adamretter