Use the default copy constructor in Options #2888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maysamyabandeh
commented
Sep 14, 2017
| ASSERT_EQ("v11", Get("foo")); | ||
| ASSERT_EQ("v12", Get("bar")); | ||
| ASSERT_EQ(2, TotalTableFiles()); | ||
| ASSERT_EQ(3, TotalTableFiles()); |
Contributor
Author
There was a problem hiding this comment.
@yiwu-arbug can you confirm this change? It seems that the test intended a force flush with setting allow_2pc but it was not effective due to absence of allow_2pc in the copy-constructor. If the force flush was intended the total number of sst files should be 3 as it is now after this patch.
Contributor
There was a problem hiding this comment.
true, thanks for fixing.
yiwu-arbug
approved these changes
Sep 15, 2017
Contributor
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of (semi-)copy constructor of DBOptions and ColumnFamilyOptions seems to intend value by value copy, which is what the default copy constructor does anyway. Moreover not using the default constructor has the risk of forgetting to add newly added options.
As an example, allow_2pc seems to be forgotten in the copy constructor which was causing one of the unit tests not seeing its effect.