Only expose FiberRoot at the top level instead of a Fiber #8934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
acdlite
approved these changes
Feb 6, 2017
It is strange to get a handle on the Fiber since it is one of possibly two root Fibers. The correct way to get the current Fiber is through the root.current. I exposed the Fiber originally because I thought we might use it for Portals but we went with a different approach. So we don't need this.
sebmarkbage
force-pushed
the
fiberroot
branch
from
3cc646c to
aed46e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is strange to get a handle on the Fiber since it is one of possibly two root Fibers. The correct way to get the current Fiber is through the root.current.
I exposed the Fiber originally because I thought we might use it for Portals but we went with a different approach. I don't think we don't need this API to be shared by Portals.