[Fiber] Updates from inside componentDidMount/Update should have Task priority #8206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
changed the title
acdlite
force-pushed
the
fibertasklifecycleupdates
branch
2 times, most recently
from
dbb161f to
ea083dc
Compare
sebmarkbage
reviewed
Nov 8, 2016
| class Foo extends React.Component { | ||
| componentDidMount() { | ||
| // Animation work that will get performed during animation callback | ||
| ReactNoop.performAnimationWork(() => { |
Collaborator
There was a problem hiding this comment.
It seems to me that we still want a test that schedules animation work and deferred work in componentDidMount. These should not be synchronous since they've explicitly opted in to being async.
sebmarkbage
approved these changes
Nov 8, 2016
Collaborator
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
Please add a test that covers the case of animation/deferred work triggered from within a componentDidMount/componentDidUpdate.
This is only observable in incremental mode.
acdlite
force-pushed
the
fibertasklifecycleupdates
branch
from
ea083dc to
d9d4ad6
Compare
Collaborator
Author
|
Added tests |
acdlite
added a commit
that referenced
this pull request
Nov 8, 2016
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only observable in incremental mode.
@gaearon, IResolvedxit-ed some of your scheduling tests that usecomponentDidMount. I was going to rewrite them, but I don't think they test what their descriptions say they test. Let me know what you think and we'll either fix the tests or remove them.