Rewrite some tests relying on internal APIs #8148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm pretty sure this is heavily used internally and also in React Native. Clean up might be a bit of work. I don't think we should delete it from the repo until we've fixed those callers - which might need to be maintained in this repo. We can land the fixes to our tests though. |
gaearon
force-pushed
the
kill-reactcomponentexpect
branch
from
2f99ed7 to
48ccf52
Compare
Collaborator
Author
|
Un-deleted |
Collaborator
Author
|
Landing fixes just to our tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes our use of
reactComponentExpect(which has never been a public API).Pretty sure it was added at some point to save the time but here we are.
I haven't checked the use of this internally yet but if we do use it, we should either change those callsites or at least put it in the contrib folder and mark as deprecated.
This bumps from 960 to 967 tests on Fiber, but more importantly, it surfaces real errors instead of artificial ones.