transferPropsTo should never transfer the "key" property #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this is good to pull in, but next time adding a unit test would be nice :) |
vjeux
added a commit
that referenced
this pull request
Dec 26, 2013
transferPropsTo should never transfer the "key" property
Contributor
Author
|
@petehunt Still learning, will keep that in mind! :) |
paulshen
added a commit
that referenced
this pull request
Jan 23, 2014
`cloneWithProps` uses `ReactPropTransferer`, which ignores the `key` prop. See #713 However, this is not the case with `cloneWithProps` because when someone is cloning a component and provides a key, they mean for the clone to take it.
toptaldev92
pushed a commit
to toptaldev92/react_project
that referenced
this pull request
Jul 28, 2021
`cloneWithProps` uses `ReactPropTransferer`, which ignores the `key` prop. See facebook/react#713 However, this is not the case with `cloneWithProps` because when someone is cloning a component and provides a key, they mean for the clone to take it.
This was referenced Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right?
Not that it should ever matter, considering they are both mounted and unmounted together, but practically it serves no purpose.