Skip to content

Conversation

@sophiebits
Copy link
Collaborator

As we move away from using HTML for updates, this becomes less useful.

Facebook has been running with this on for a couple weeks now with no ill effects.
As we move away from using HTML for updates, this becomes less useful.
@sophiebits
Copy link
Collaborator Author

@sebmarkbage I think this is most of the contortions we had to support HTML batching. I took the opportunity to make it a little more functional since I was changing it.

@sebmarkbage
Copy link
Collaborator

I'll trade you some green for your red.

sophiebits added a commit that referenced this pull request Nov 25, 2015
Kill global queue in ReactMultiChild
@sophiebits sophiebits merged commit 8248470 into facebook:master Nov 25, 2015
@troydemonbreun
Copy link
Contributor

@spicyj it seems that propName warnings don't trigger now due to useCreateElementdefault change? I think because _createOpenTagMarkupAndPutListeners is not called which triggers the warning event.

@sophiebits
Copy link
Collaborator Author

@troydemonbreun Do you mean like if you miscapitalize a prop name?

@troydemonbreun
Copy link
Contributor

Right
On Apr 22, 2016 5:50 PM, "Ben Alpert" [email protected] wrote:

@troydemonbreun https://github.com/troydemonbreun Do you mean like if
you miscapitalize a prop name?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5547 (comment)

@sophiebits
Copy link
Collaborator Author

Thanks, I see that #6585 fails on my machine. @jimfb Can you take a look at this?

@jimfb
Copy link
Contributor

jimfb commented Apr 23, 2016

Yep, assigned to self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants