Skip to content

Make sure react-dom-server is shipped in release process #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2015
+18 −40
Merged

Make sure react-dom-server is shipped in release process #5501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ module.exports = function(grunt) {
'npm-react:release',
]);
grunt.registerTask('build:react-dom', require('./grunt/tasks/react-dom'));
grunt.registerTask('build:react-dom-server', require('./grunt/tasks/react-dom-server'));

grunt.registerTask('test', ['jest']);
grunt.registerTask('npm:test', ['build', 'npm:pack']);
Expand All @@ -128,7 +127,6 @@ module.exports = function(grunt) {
'browserify:min',
'browserify:addonsMin',
'build:react-dom',
'build:react-dom-server',
'npm-react:release',
'npm-react:pack',
'npm-react-dom:release',
Expand Down
2 changes: 2 additions & 0 deletions grunt/tasks/npm-react-dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ var dist = dest + 'dist/';
var distFiles = [
'react-dom.js',
'react-dom.min.js',
'react-dom-server.js',
'react-dom-server.min.js',
];

function buildRelease() {
Expand Down
27 changes: 0 additions & 27 deletions grunt/tasks/react-dom-server.js
View file
Open in desktop

This file was deleted.

25 changes: 14 additions & 11 deletions grunt/tasks/react-dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,25 @@ var UglifyJS = require('uglify-js');
var LICENSE_TEMPLATE =
grunt.file.read('./grunt/data/header-template-extended.txt');

module.exports = function() {
function build(name, filename) {
var srcFile = `vendor/${filename}.js`;
var destFile = `build/${filename}.js`;
var destFileMin = `build/${filename}.min.js`;
var templateData = {
package: 'ReactDOM',
package: name,
version: grunt.config.data.pkg.version,
};
var header = grunt.template.process(
LICENSE_TEMPLATE,
{data: templateData}
);
var src = grunt.file.read('vendor/react-dom.js');
grunt.file.write(
'build/react-dom.js',
header + src
);
grunt.file.write(
'build/react-dom.min.js',
header + UglifyJS.minify(src, {fromString: true}).code
);
var src = grunt.file.read(srcFile);
var srcMin = UglifyJS.minify(src, {fromString: true}).code;
grunt.file.write(destFile, header + src);
grunt.file.write(destFileMin, header + srcMin);
}

module.exports = function() {
build('ReactDOM', 'react-dom');
build('ReactDOMServer', 'react-dom-server');
};
2 changes: 2 additions & 0 deletions grunt/tasks/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ var BOWER_FILES = [
'react-with-addons.min.js',
'react-dom.js',
'react-dom.min.js',
'react-dom-server.js',
'react-dom-server.min.js',
];

var EXAMPLES_PATH = 'examples/';
Expand Down