Skip to content

fix(hooks): add dev warning when useEffectEvent callback is not a function #34687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(hooks): add dev warning when useEffectEvent callback is not a function #34687

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d1b4418
fix(hooks): add dev warning when useEffectEvent callback is not a fun…
li-jia-nan Oct 2, 2025
c3368d3
lint
li-jia-nan Oct 2, 2025
1449352
Merge branch 'main' into useEffectEvent-warn
li-jia-nan Oct 2, 2025
8e7ec04
Merge branch 'main' into useEffectEvent-warn
li-jia-nan Oct 2, 2025
ba0662c
Merge branch 'main' into useEffectEvent-warn
li-jia-nan Oct 6, 2025
9bff9e3
Merge branch 'main' into useEffectEvent-warn
li-jia-nan Oct 8, 2025
df1099c
Merge branch 'main' into useEffectEvent-warn
li-jia-nan Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react/src/ReactHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,13 @@ export function useMemoCache(size: number): Array<mixed> {
export function useEffectEvent<Args, F: (...Array<Args>) => mixed>(
callback: F,
): F {
if (__DEV__) {
if (typeof callback !== 'function') {
console.warn(
`React Hook useEffectEvent expected a function, but received ${typeof callback}`,
);
}
}
const dispatcher = resolveDispatcher();
// $FlowFixMe[not-a-function] This is unstable, thus optional
return dispatcher.useEffectEvent(callback);
Expand Down