[playground] Fix syntax error from crashing the Compiler playground #34623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianduvall
changed the title
Member
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
nice! I'll let @EugeneChoi4 review, just a quick comment. the interface declaration is in a kind of random spot, we should maybe centralize that if it's necessary
Contributor
|
Thanks for the help! I'll be able to approve when you address the interface question. |
EugeneChoi4
approved these changes
Oct 2, 2025
ianduvall
force-pushed
the
playground-crash-syntax-error
branch
from
5c0b5f8 to
84a486f
Compare
ianduvall
force-pushed
the
playground-crash-syntax-error
branch
from
84a486f to
b45e796
Compare
EugeneChoi4
approved these changes
Oct 9, 2025
This was referenced Oct 10, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
…acebook#34623) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> Fixes a syntax error causing the Compiler playground to crash. Resolves facebook#34622. ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> Tested locally and added a test. <img width="1470" height="836" alt="Screenshot 2025-09-27 at 8 13 07 AM" src="https://github.com/user-attachments/assets/29473682-94c3-49dc-9ee9-c2004062aaea" /> DiffTrain build for [06fcc8f](facebook@06fcc8f)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
…acebook#34623) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> Fixes a syntax error causing the Compiler playground to crash. Resolves facebook#34622. ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> Tested locally and added a test. <img width="1470" height="836" alt="Screenshot 2025-09-27 at 8 13 07 AM" src="https://github.com/user-attachments/assets/29473682-94c3-49dc-9ee9-c2004062aaea" /> DiffTrain build for [06fcc8f](facebook@06fcc8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a syntax error causing the Compiler playground to crash. Resolves #34622. Resolves #34623
How did you test this change?
Tested locally and added a test.