Skip to content

[compiler] Have react-compiler eslint plugin return a RuleModule #34421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

[compiler] Have react-compiler eslint plugin return a RuleModule #34421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion compiler/packages/eslint-plugin-react-compiler/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,8 @@ const configs = {
},
};

export {configs, allRules as rules, meta};
const rules = Object.fromEntries(
Object.entries(allRules).map(([name, {rule}]) => [name, rule]),
);

export {configs, rules, meta};
Copy link
Member

@josephsavona josephsavona Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine. we really need to get rid of this plugin and use the main eslint-plugin-react-hooks one though

Copy link
Contributor Author

@jorge-cab jorge-cab Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I could probably help with this if no one is looking at it already

Loading