Skip to content

fix: correct spelling mistakes in code and error messages #34118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rinilkunhiraman
Copy link

Summary

Fix a consistent spelling error in SuspenseList component error messages. The word 'explicitly' was misspelled as 'explictly' in error messages that warn developers about future-compatibility requirements for SuspenseList props.

Problem: User-facing error messages contained the typo "explictly" instead of "explicitly", which affects the professionalism and clarity of React's developer experience.

Solution:

  • Fixed typo in ReactFiberBeginWork.js error messages (2 locations)
  • Updated corresponding test expectations in ReactSuspenseList-test.js (2 locations)

This ensures consistency between runtime error messages and their test expectations.

How did you test this change?

Verification steps taken:

  1. Code Review: Manually verified all 4 instances of the typo were corrected

    • Lines 3174 and 3241 in ReactFiberBeginWork.js
    • Lines 259 and 1717 in ReactSuspenseList-test.js
  2. File Validation: Confirmed only the intended files were modified:

    git diff --name-only HEAD~1
    # Output: packages/react-reconciler/src/ReactFiberBeginWork.js
    #         packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js

Fix a consistent spelling error in error messages for SuspenseList props.
The typo appears in both runtime error messages in ReactFiberBeginWork.js
and corresponding test expectations in ReactSuspenseList-test.js.

Changed:
- 'explictly' → 'explicitly' in revealOrder prop error message
- 'explictly' → 'explicitly' in tail prop error message
Copy link

meta-cla bot commented Aug 6, 2025

Hi @rinilkunhiraman!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@rinilkunhiraman
Copy link
Author

CLA signed

- Fix 'teh' → 'the' in ReactFiberConfigDOM.js comment
- Fix 'occured' → 'occurred' in ErrorBoundary.js error message and test comment
- Fix 'propogate' → 'propagate' in ConstantPropagation.ts comments (4 instances)
- Fix 'compatability' → 'compatibility' in Environment.ts comment

These changes improve code quality and fix user-facing error messages.
@meta-cla meta-cla bot added the CLA Signed label Aug 6, 2025
@rinilkunhiraman rinilkunhiraman changed the title Fix typo: 'explictly' → 'explicitly' in SuspenseList error messages fix: correct spelling mistakes in code and error messages Aug 6, 2025
@SaurabhCodesAI
Copy link

Looks good to me spelling fixes only, CI is passing, CLA signed, no conflicts. Safe to merge

@rinilkunhiraman
Copy link
Author

LGTM — spelling-only changes. CLA check passed, imports/internal checks passed. Vercel is green; Codesandbox is still pending after updating the branch. No conflicts. Safe to merge (squash) once checks are green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants