Skip to content

[tests] Assert on component stack for Maximum Update error #33686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025
Merged

[tests] Assert on component stack for Maximum Update error #33686

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76a8c9e
[tests] Test component stack for Maximum Update error
rickhanlonii Jul 2, 2025
13ccc06
add ref test
rickhanlonii Jul 2, 2025
c93422f
cleanup
rickhanlonii Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 31 additions & 7 deletions packages/react-dom/src/__tests__/ReactUpdates-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,19 @@
let assertLog;
let assertConsoleErrorDev;

function normalizeCodeLocInfo(str) {
return (
str &&
str.replace(/^ +(?:at|in) ([\S]+)[^\n]*/gm, function (m, name) {
const dot = name.lastIndexOf('.');
if (dot !== -1) {
name = name.slice(dot + 1);
}
return ' in ' + name + (/\d/.test(m) ? ' (at **)' : '');
})
);
}

describe('ReactUpdates', () => {
beforeEach(() => {
jest.resetModules();
Expand Down Expand Up @@ -1972,13 +1985,24 @@
}

const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await expect(async () => {
await act(() => {
ReactDOM.flushSync(() => {
root.render(<NonTerminating />);
});
let errors = [];

Check failure on line 1988 in packages/react-dom/src/__tests__/ReactUpdates-test.js

View workflow job for this annotation

GitHub Actions / Run eslint 

'errors' is never reassigned. Use 'const' instead
const root = ReactDOMClient.createRoot(container, {
onUncaughtError: (error, errorInfo) => {
errors.push(
error.message,
normalizeCodeLocInfo(errorInfo.componentStack),
);
},
});
await act(() => {
ReactDOM.flushSync(() => {
root.render(<NonTerminating />);
});
}).rejects.toThrow('Maximum update depth exceeded');
});

expect(errors).toEqual([
'Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.',
'\n in NonTerminating (at **)',
]);
});
});
Loading