-
Notifications
You must be signed in to change notification settings - Fork 49.9k
feat(ReactNative): prioritize attribute config process function to allow processing function props
#32119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
javache
merged 11 commits into
facebook:main
from
hannojg:feat/prioritize-view-attribute-process-function
Jun 9, 2025
Merged
feat(ReactNative): prioritize attribute config process function to allow processing function props
#32119
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
23c18b9
feat: prioritize attribute config process function to allow processin…
hannojg 2d205b9
Merge branch 'main' into feat/prioritize-view-attribute-process-function
hannojg 7adf510
add is object chec
hannojg 3b6eb4d
add test that verifies process function is used for function props as…
hannojg a853ef5
Merge branch 'main' into feat/prioritize-view-attribute-process-function
hannojg cf9168f
handle diffProperties as well
hannojg ca657bf
prettier
hannojg 25b1b72
Merge branch 'main' into feat/prioritize-view-attribute-process-function
hannojg 12b2e7d
avoid the multiple typeof calls since this is a hot codepath
hannojg 9e74020
don't process too early, just don't set the function prop to true if …
hannojg 04c854e
Merge branch 'main' into feat/prioritize-view-attribute-process-function
hannojg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is correct. You're assuming now that
attributeConfigis always going to be an object which you can readprocessfunction of.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, good catch tanks. Added an additional check for object. Will also add unit tests in a moment