Remove consoleManagedByDevToolsDuringStrictMode #31755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: a7b8295...33e1f8c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
reviewed
Dec 13, 2024
| // suppress warnings and disable scheduler yielding during the double render | ||
| unstable_setDisableYieldValue(newIsStrictMode); | ||
| setSuppressWarning(newIsStrictMode); | ||
| } |
Collaborator
There was a problem hiding this comment.
We should get rid of this hack at some point. I don't think it was meant to survive the roll out.
Member
Author
There was a problem hiding this comment.
Yeah I'll fix that outside this diff now that I branched off it
sebmarkbage
approved these changes
Dec 13, 2024
hoxyq
approved these changes
Dec 13, 2024
rickhanlonii
added a commit
that referenced
this pull request
Dec 13, 2024
Based off #31755 This is landed everywhere.
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 13, 2024
Based off facebook#31755 This is landed everywhere. DiffTrain build for [fb12845](facebook@fb12845)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 13, 2024
Based off facebook#31755 This is landed everywhere. DiffTrain build for [fb12845](facebook@fb12845)
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enabled everywhere except the test renderers, which don't use it.