Skip to content

Avoid acccessing React internals from use-sync-external-store/shim #29868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Avoid acccessing React internals from use-sync-external-store/shim #29868

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
022982d
Avoid acccessing React internals from `use-sync-external-store/shim`.
phryneas Jun 12, 2024
ebed29a
add explainer comments
phryneas Jun 12, 2024
1c9469f
add a test
phryneas Jun 12, 2024
bd74325
simpler test
phryneas Jun 12, 2024
fa405cf
adjust
phryneas Jun 12, 2024
9e7ebbe
Merge branch 'main' into pr/uSES-avoid-internals-access
phryneas Jun 12, 2024
f004f77
nudge CI
phryneas Jun 12, 2024
772b83d
Enable tests with `use-sync-external-store/shim` and react-dom@17
eps1lon Jun 12, 2024
76042b0
wording
eps1lon Jun 12, 2024
c12120a
Fix assertions
eps1lon Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/use-sync-external-store/src/useSyncExternalStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import * as React from 'react';
export const useSyncExternalStore = React.useSyncExternalStore;

if (__DEV__) {
console.error(
console['error'](
"The main 'use-sync-external-store' entry point is not supported; all it " +
"does is re-export useSyncExternalStore from the 'react' package, so " +
'it only works with React 18+.' +
Expand Down
4 changes: 2 additions & 2 deletions packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export function useSyncExternalStore<T>(
if (!didWarnOld18Alpha) {
if (React.startTransition !== undefined) {
didWarnOld18Alpha = true;
console.error(
console['error'](
'You are using an outdated, pre-release alpha of React 18 that ' +
'does not support useSyncExternalStore. The ' +
'use-sync-external-store shim will not work correctly. Upgrade ' +
Expand All @@ -59,7 +59,7 @@ export function useSyncExternalStore<T>(
if (!didWarnUncachedGetSnapshot) {
const cachedValue = getSnapshot();
if (!is(value, cachedValue)) {
console.error(
console['error'](
'The result of getSnapshot should be cached to avoid an infinite loop',
);
didWarnUncachedGetSnapshot = true;
Expand Down