Repro for mismatch of changed hook and used hook #28587
Closed
+248
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
force-pushed
the
devtools/hook-changed-mismatch
branch
from
2165efb to
ca6eb7c
Compare
eps1lon
commented
Mar 19, 2024
| "context": false, | ||
| "didHooksChange": true, | ||
| "hooks": [ | ||
| 31, |
Collaborator
Author
There was a problem hiding this comment.
We don't have that many hooks. Highest index is 29. It should probably be 28 since that's the index of the React.useSyncExternalStore call.
eps1lon
force-pushed
the
devtools/hook-changed-mismatch
branch
from
ca6eb7c to
5be8ef9
Compare
Contributor
|
This can be closed now; it has been fixed in #34547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test reproducing #28584. This is not minimal since I haven't started removing wrappers until it no longer reproduces. But this should be a good starting point if somebody wants to pick this up.
Test plan
yarn test --build --project=devtools -r=experimental profilingCache-test --testNamePattern "should properly detect changed hooks #2"