[Flight] Refactor emit and process functions #27234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pattern is more inline with the other reuses.
This one still is around and is kind of a special case.
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
approved these changes
Aug 16, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 22, 2023
### React upstream changes - facebook/react#27265 - facebook/react#27259 - facebook/react#27264 - facebook/react#27257 - facebook/react#27258 - facebook/react#27187 - facebook/react#27243 - facebook/react#27205 - facebook/react#27220 - facebook/react#27238 - facebook/react#27234 - facebook/react#27224 - facebook/react#27223 - facebook/react#27222 This will help unblock #53906
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Since we no longer have externally configured "process" methods, I just inlined all of those. The main thing in this refactor is that I just inlined all the error branches into just `emitErrorChunk`. I'm not sure why it was split up an repeated before but this seems simpler. I need it since I'm going to be doing similar copies of this.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Since we no longer have externally configured "process" methods, I just inlined all of those. The main thing in this refactor is that I just inlined all the error branches into just `emitErrorChunk`. I'm not sure why it was split up an repeated before but this seems simpler. I need it since I'm going to be doing similar copies of this. DiffTrain build for commit ade82b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer have externally configured "process" methods, I just inlined all of those.
The main thing in this refactor is that I just inlined all the error branches into just
emitErrorChunk. I'm not sure why it was split up an repeated before but this seems simpler. I need it since I'm going to be doing similar copies of this.