When selecting a package variant from an export map we should favor n… #27030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode over edge-light
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 1fdacbe...1487aa7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Jul 6, 2023
styfle
added a commit
to vercel/next.js
that referenced
this pull request
Jul 13, 2023
### React upstream changes - facebook/react#27096 - facebook/react#27069 - facebook/react#27033 - facebook/react#27061 - facebook/react#27030 - facebook/react#27056
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
facebook#27030) When selecting a package variant from an export map we should favor node over edge-light edge-light represents a runtime with some minimal set of web apis generally found across edge runtimes. However some environments might be both edge-light compatible and node compatible and (node is adding many web APIs) and when both conditions exist we want to favor the node implementations. A followup to this change will add the web streams APIs to Flight and Fizz so the node version exports the same interfaces for web streams that edge does in addition to the node specific implementations.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
#27030) When selecting a package variant from an export map we should favor node over edge-light edge-light represents a runtime with some minimal set of web apis generally found across edge runtimes. However some environments might be both edge-light compatible and node compatible and (node is adding many web APIs) and when both conditions exist we want to favor the node implementations. A followup to this change will add the web streams APIs to Flight and Fizz so the node version exports the same interfaces for web streams that edge does in addition to the node specific implementations. DiffTrain build for commit a19bbeb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a package variant from an export map we should favor node over edge-light
edge-light represents a runtime with some minimal set of web apis generally found across edge runtimes. However some environments might be both edge-light compatible and node compatible and (node is adding many web APIs) and when both conditions exist we want to favor the node implementations. A followup to this change will add the web streams APIs to Flight and Fizz so the node version exports the same interfaces for web streams that edge does in addition to the node specific implementations.