Skip to content

Reactdevtools -----> Modal deleting filter fix #22481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Reactdevtools -----> Modal deleting filter fix #22481

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d7b0cc
modal closing deleting fix
Biki-das Oct 1, 2021
d4e2232
Added requested changes
Biki-das Oct 1, 2021
7ed35ac
Update hooks.js
Biki-das Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-devtools-shared/src/devtools/views/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@ export function useModalDismissSignal(
ownerDocument.addEventListener('keydown', handleDocumentKeyDown);
if (dismissOnClickOutside) {
ownerDocument.addEventListener('click', handleDocumentClick);
ownerDocument.removeEventListener('click', handleDocumentClick,true);

Copy link
Contributor

@bvaughn bvaughn Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. This is not what I meant.

We add event listeners in the effects body and we remove them in the cleanup function the effect returns.

We need to add the new useCapture param to both places not just addEventListener

Copy link
Contributor

@bvaughn bvaughn Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ownerDocument.addEventListener('click', handleDocumentClick, true);

Copy link
Contributor Author

@Biki-das Biki-das Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @bvaughn i closed this one as i messed up the repo will be pulling another pr now

}
}, 0);

Expand Down