Skip to content

Conversation

@acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 22, 2021

There's a downstream workflow that runs the print-warnings command. We can make it faster by scraping the warnings in CI and storing the result as a build artifact.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Sep 22, 2021
@acdlite acdlite force-pushed the scrape-warning-messages branch from d7273e7 to e272bf1 Compare September 22, 2021 01:49
@sizebot
Copy link

sizebot commented Sep 22, 2021

Comparing: ba07042...359ceea

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.37 kB 127.37 kB = 40.58 kB 40.58 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.19 kB 130.19 kB = 41.50 kB 41.50 kB
facebook-www/ReactDOM-prod.classic.js = 405.41 kB 405.41 kB = 75.05 kB 75.05 kB
facebook-www/ReactDOM-prod.modern.js = 394.00 kB 394.00 kB = 73.34 kB 73.34 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.41 kB 405.41 kB = 75.05 kB 75.05 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 359ceea

@acdlite acdlite force-pushed the scrape-warning-messages branch from e272bf1 to 24c934f Compare September 22, 2021 01:56
There's a downstream workflow that runs the `print-warnings` command. We
can make it faster by scraping the warnings in CI and storing the
result as a build artifact.
@acdlite acdlite force-pushed the scrape-warning-messages branch from 24c934f to 359ceea Compare September 22, 2021 01:58
@acdlite acdlite merged commit 8fcfdff into facebook:main Sep 22, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
There's a downstream workflow that runs the `print-warnings` command. We
can make it faster by scraping the warnings in CI and storing the
result as a build artifact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants